-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding SQL AutoDR support #1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @franktsa, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
||
try | ||
{ | ||
$server1 = Create-ServerForTest $rg1 "12.0" $location1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franktsa please align indentation. Replace tab with 4 spaces in the file.
- Replaced tabs with spaces in test file - Removed Authentication reference in packages.config
@@ -269,6 +280,10 @@ | |||
<SpecificVersion>False</SpecificVersion> | |||
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath> | |||
</Reference> | |||
<Reference Include="Microsoft.Azure.Common.Authentication"> | |||
<HintPath>..\..\..\packages\Microsoft.Azure.Common.Authentication.1.4.1-preview\lib\net45\Microsoft.Azure.Common.Authentication.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this. You need to reference solution in the repo
- Removed reference to Microsoft.WindowsAzure.ConfigurationManager
@franktsa What are the plans for adding help for these cmdlets? Also, can you please send a PR with updates to the ChangeLog for these cmdlets? |
Adding support for AutoDr functionality, which is a configuration object under the server. Operations include:
•Create (PUT)
•Read (GET)
•Update / Failover (POST)
•Delete (DELETE)
CR: http://codeflow/dashboard/review/display/franktsa-c410159bf86f4ca8b7a9f2c6b5768b9f