Skip to content

Fix the unit tests #16863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Fix the unit tests #16863

merged 1 commit into from
Jan 19, 2022

Conversation

kceiw
Copy link
Contributor

@kceiw kceiw commented Jan 18, 2022

Description

In previous check in there was a change to create the PowerShell Runtime when the module is imported. But the unit tests don't set up the PowerShell environment. The creation of PowerShell runtime will fail.

The fix is to abstract PowerShellRuntime to an interface IPowerShellRuntime. We create a mock of IPowerShellRuntime for the unit tests and we only initialize the needed properties. Thus we avoid creation of the PowerShell Runtime in the unit tests.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit 4b0acde into Azure:main Jan 19, 2022
@kceiw kceiw deleted the mahuang/FixTest branch February 14, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants