Skip to content

Update to R5 RP 2019-07-01 API #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Update to R5 RP 2019-07-01 API #10445

merged 2 commits into from
Nov 6, 2019

Conversation

leonardbf
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

- nfsv4 renamed to nfsv4.1
 - snapshot cration date renamed to created
@wyunchi-ms
Copy link
Contributor

Hi @leonardbf , the change of output will be a breaking change, we can only accept these PR at a breaking change release.

@leonardbf
Copy link
Contributor Author

Hi @leonardbf , the change of output will be a breaking change, we can only accept these PR at a breaking change release.

ok, thanks. My first thought though is to confirm that the NetApp PowerShell is not in preview. Of course the service is GA but I thought the ANF PS itself was still in preview. At least I know that the CLI is still in preview but I'm not sure where to check for the PS.

If it is indeed not preview, when can we expect a breaking change release, how often do they occur? Is there any action required by me?

Finally, how can we handle this going forward. We have new swaggers almost monthly at the moment, and I'd expect each of these to cause breaking changes in the resulting PowerShell. Actually, this also makes me wonder whether the last update to ANF PS, relating to swagger version 2019-06-01, also involved breaking changes.

@wyunchi-ms
Copy link
Contributor

Hi @leonardbf we do ignite release every 6 months. Unfortunately our ignite release just finish at 2019-11-04, so the next ignite release will be in 2020 May. I think if your cmdlets is not stable, you can publish them in preview version first. You can find some info here.

@wyunchi-ms
Copy link
Contributor

Hi @leonardbf sorry I misunstand your words. I thought your module is already in GA. It's acceptable since your module is not in GA yet.

@wyunchi-ms wyunchi-ms merged commit f7382d9 into Azure:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants