[Application insight] Fix update component (#24405)

* fix application insight update cmdlet * revert group logic in Application insights test utils
Azure · Mar 19, 2024 · e3757db · e3757db
1 parent a9bd00b
commit e3757db
Show file tree

Hide file tree

Showing 5 changed files with 338 additions and 56 deletions.
diff --git a/src/ApplicationInsights/ApplicationInsights.Autorest/custom/Update-AzApplicationInsights.ps1 b/src/ApplicationInsights/ApplicationInsights.Autorest/custom/Update-AzApplicationInsights.ps1
@@ -206,8 +206,38 @@ function Update-AzApplicationInsights {
     )
 
     process {
+        # add PS bound parameters to run test
+        $EnvPSBoundParameters = @{}
+        if ($PSBoundParameters.ContainsKey('Debug')) {
+            $EnvPSBoundParameters['Debug'] = $Debug
+        }
+        if ($PSBoundParameters.ContainsKey('HttpPipelineAppend')) {
+            $EnvPSBoundParameters['HttpPipelineAppend'] = $HttpPipelineAppend
+        }
+        if ($PSBoundParameters.ContainsKey('HttpPipelinePrepend')) {
+            $EnvPSBoundParameters['HttpPipelinePrepend'] = $HttpPipelinePrepend
+        }
+        if ($PSBoundParameters.ContainsKey('Proxy')) {
+            $EnvPSBoundParameters['Proxy'] = $Proxy
+        }
+        if ($PSBoundParameters.ContainsKey('ProxyCredential')) {
+            $EnvPSBoundParameters['ProxyCredential'] = $ProxyCredential
+        }
+        if ($PSBoundParameters.ContainsKey('ProxyUseDefaultCredentials')) {
+            $EnvPSBoundParameters['ProxyUseDefaultCredentials'] = $ProxyUseDefaultCredentials
+        }
+        if ($PSBoundParameters.ContainsKey('SubscriptionId')) {
+            $EnvPSBoundParameters['SubscriptionId'] = $SubscriptionId
+        }
+        if ($PSBoundParameters.ContainsKey('ResourceGroupName')) {
+            $EnvPSBoundParameters['ResourceGroupName'] = $ResourceGroupName
+        }
+        if ($PSBoundParameters.ContainsKey('Name')) {
+            $EnvPSBoundParameters['Name'] = $Name
+        }
+
         try {
-            $component = . Get-AzApplicationInsights -SubscriptionId $PSBoundParameters["SubscriptionId"] -ResourceGroupName $PSBoundParameters["ResourceGroupName"] -Name $PSBoundParameters["Name"]
+            $component = . Get-AzApplicationInsights @EnvPSBoundParameters
         } catch {
             Write-Warning "component $($PSBoundParameters['Name']) is not existed in Resource Group $($PSBoundParameters["ResourceGroupName"])"
             return
@@ -258,7 +288,7 @@ function Update-AzApplicationInsights {
             $PSBoundParameters["SamplingPercentage"] = $component.SamplingPercentage
         }
         if (!$PSBoundParameters.ContainsKey("Tag") -and ($null -ne $component.Tag)) {
-            $PSBoundParameters["Tag"] = [System.Collections.Hashtable]$component.Tag.AddtionalProperties
+            $PSBoundParameters["Tag"] = [System.Collections.Hashtable]$component.Tag.AdditionalProperties
         }
         if (!$PSBoundParameters.ContainsKey("WorkspaceResourceId") -and ![System.String]::IsNullOrEmpty($component.WorkspaceResourceId)) {
             $PSBoundParameters["WorkspaceResourceId"] = $component.WorkspaceResourceId