Fix changes suggested in PR

Author: rajsing

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/NewAzureStorSimpleNetworkConfig.cs

@@ -109,6 +109,7 @@ public class NewAzureStorSimpleNetworkConfig : StorSimpleCmdletBase
         private IPAddress ipv4Gateway;
         private IPAddress ipv4Netmask;
         private IPAddress ipv6Gateway;
+        NetInterfaceId interfaceAlias;
 
         public override void ExecuteCmdlet()
         {
@@ -130,7 +131,7 @@ public override void ExecuteCmdlet()
                     IPv4Address = ipv4Address,
                     IPv6Prefix = IPv6Prefix,
                     IPv4Netmask = ipv4Netmask,
-                    InterfaceAlias = (NetInterfaceId)Enum.Parse(typeof(NetInterfaceId), InterfaceAlias)
+                    InterfaceAlias = interfaceAlias
                 };
 
                 WriteObject(netConfig);
@@ -144,6 +145,14 @@ public override void ExecuteCmdlet()
         }
 
         private bool ProcessParameters(){
+            // parse interfaceAlias
+            if (!Enum.TryParse<NetInterfaceId>(InterfaceAlias, out interfaceAlias))
+            {
+                WriteVerbose(string.Format(Resources.InvalidInterfaceId, InterfaceAlias));
+                return false;
+            }
+
+            // Try and set all the IP address
             if (!TrySetIPAddress(Controller0IPv4Address, out controller0Address, "Controller0IPv4Address"))
             {
                 return false;

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceJobs/GetAzureStorSimpleJob.cs

@@ -44,7 +44,7 @@ public class GetAzureStorSimpleJob : StorSimpleCmdletBase
         /// <summary>
         /// InstanceId/JobId of the job to retrieve
         /// </summary>
-        [Parameter(Position = 0, ParameterSetName = StorSimpleCmdletParameterSet.IdentifyById,
+        [Parameter(Mandatory=true, Position = 0, ParameterSetName = StorSimpleCmdletParameterSet.IdentifyById,
             HelpMessage = StorSimpleCmdletHelpMessage.DeviceJobId)]
         public string JobId { get; set; }
 
@@ -160,8 +160,7 @@ private bool ProcessParameters()
 
             Skip = Skip ?? 0;
 
-            // Need to use xml convert because we want ISO 8601 formatting to avoid deserialization
-            // probs in the backend.
+            // Need to use xml convert because we want ISO 8601 formatting - which is a mandatory requirement from the backend.
             fromDateTimeIsoString = From.HasValue ? XmlConvert.ToString(From.Value) : null;
 
             toDateTimeIsoString = To.HasValue ? XmlConvert.ToString(To.Value) : null;           

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceJobs/StopAzureStorSimpleJob.cs

@@ -32,7 +32,7 @@ public class StopAzureStorSimpleJob : StorSimpleCmdletBase
         /// <summary>
         /// Device job id of the job to stop.
         /// </summary>
-        [Parameter(Mandatory = true, Position = 0, ParameterSetName = StorSimpleCmdletParameterSet.IdentifyById, HelpMessage = StorSimpleCmdletHelpMessage.DeviceJobId)]
+        [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.DeviceJobId)]
         [ValidateNotNullOrEmptyAttribute]
         public string JobId { get; set; }
 

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -498,4 +498,7 @@
   <data name="StartASSBackupCloneJobWarningMessage" xml:space="preserve">
     <value>Are you sure you want to clone the backup with backupId {0}?</value>
   </data>
+  <data name="InvalidInterfaceId" xml:space="preserve">
+    <value>{0} is not a valid InterfaceAlias!</value>
+  </data>
 </root>