Skip to content

Commit 740b137

Browse files
minor fix in New-AzureRmSignalR
1 parent 22b71fb commit 740b137

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/ResourceManager/SignalR/Commands.SignalR/Cmdlets/NewAzureRmSignalR.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
using System.Collections.Generic;
2222
using System.Management.Automation;
2323
using System.Threading.Tasks;
24-
using System;
2524
using Microsoft.Azure.Commands.SignalR.Strategies.ResourceManager;
2625
using System.Threading;
2726
using Microsoft.Azure.Commands.SignalR.Strategies.SignalRRp;
@@ -107,14 +106,16 @@ public Parameters(NewAzureRmSignalR cmdlet)
107106
public async Task<ResourceConfig<SignalRResource>> CreateConfigAsync()
108107
{
109108
_cmdlet.ResourceGroupName = _cmdlet.ResourceGroupName ?? _cmdlet.Name;
110-
var resourceGroup = ResourceGroupStrategy.CreateResourceGroupConfig(_cmdlet.ResourceGroupName);
109+
110+
var resourceGroup = ResourceGroupStrategy.CreateResourceGroupConfig(
111+
_cmdlet.ResourceGroupName);
112+
111113
return SignalRStrategy.Strategy.CreateResourceConfig(
112114
resourceGroup: resourceGroup,
113115
name: _cmdlet.Name,
114-
createModel: engine =>
115-
new SignalRResource(
116+
createModel: engine => new SignalRResource(
116117
tags: _cmdlet.Tag,
117-
signalrsku: new ResourceSku(_cmdlet.Sku),
118+
signalrsku: _cmdlet.Sku == null ? null : new ResourceSku(name: _cmdlet.Sku),
118119
hostNamePrefix: _cmdlet.HostNamePrefix));
119120
}
120121
}

src/ResourceManager/SignalR/Commands.SignalR/Strategies/CmdletExtensions.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,10 @@ public IEnumerable<KeyValuePair<string, object>> Parameters
4040
return typeof(T)
4141
.GetProperties()
4242
.Where(p => p
43-
.GetCustomAttributes(false)
44-
.OfType<ParameterAttribute>()
45-
.Any(a => a.ParameterSetName == psName))
43+
.GetCustomAttributes(false)
44+
.OfType<ParameterAttribute>()
45+
.Any(a => a.ParameterSetName == psName)
46+
&& p.Name != "DefaultProfile")
4647
.Select(p => new KeyValuePair<string, object>(p.Name, p.GetValue(_Cmdlet)));
4748
}
4849
}

src/ResourceManager/SignalR/Commands.SignalR/Strategies/SignalRRp/SignalRStrategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ static class SignalRStrategy
88
{
99
public static ResourceStrategy<SignalRResource> Strategy { get; }
1010
= ResourceStrategy.Create(
11-
type: new ResourceType("Microsoft.SignalR", "signalRs"),
11+
type: new ResourceType("Microsoft.SignalRService", "signalRs"),
1212
getOperations: (SignalRManagementClient client) => client.Signalr,
1313
getAsync: (o, p) => o.GetAsync(p.ResourceGroupName, p.Name, p.CancellationToken),
1414
createOrUpdateAsync: (o, p) => o.CreateOrUpdateAsync(

0 commit comments

Comments
 (0)