Merge pull request #40 from AzCiS/onesdk-p2-sumanths

Added check to ensure volume container creation is allowed only if mandatory config has been done

Author: parvezah

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DataContainer/NewAzureStorSimpleDeviceVolumeContainer.cs

@@ -60,12 +60,25 @@ public override void ExecuteCmdlet()
                 string deviceid = StorSimpleClient.GetDeviceId(DeviceName);
                 if (deviceid == null)
                 {
-                    WriteVerbose(string.Format(Resources.NoDeviceFoundWithGivenNameInResourceMessage, StorSimpleContext.ResourceName, DeviceName));
-                    WriteObject(null);
-                    return;
+                    throw new ArgumentException(string.Format(Resources.NoDeviceFoundWithGivenNameInResourceMessage, StorSimpleContext.ResourceName, DeviceName));
                 }
 
-                if(EncryptionEnabled == true && (string.IsNullOrEmpty(EncryptionKey) || !IsValidAsciiString(EncryptionKey)))
+                // Get the current device details.
+                var deviceDetails = StorSimpleClient.GetDeviceDetails(deviceid);
+                if (deviceDetails == null || deviceDetails.DeviceProperties == null)
+                {
+                    throw new ArgumentException(string.Format(Resources.NoDeviceFoundWithGivenNameInResourceMessage, StorSimpleContext.ResourceName, DeviceName));
+                }
+
+                // If the device has not yet been configured with the mandatory params, then don't allow the volume-container creation
+                // TBD : This check should ideally be in the service code, but is being put here as we want to avoud a major change 
+                // to the service so late in the current release cycle. Once this fix has been migrated to the service, this check can be removed from here
+                if (!deviceDetails.DeviceProperties.IsConfigUpdated)
+                {
+                    throw new ArgumentException(Resources.DeviceNotConfiguredMessage);
+                }
+
+                if (EncryptionEnabled == true && (string.IsNullOrEmpty(EncryptionKey) || !IsValidAsciiString(EncryptionKey)))
                 {
                     throw new ArgumentException(Resources.EncryptionKeyNotAcceptableMessage);
                 }