Add ADM Support #248
Open
Add ADM Support #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b6dc7d.
Some services/receivers are only necessary when using ADM. For initial debugging, etc. we had put them in the `main` source set manifest. This commit creates ADM specific manifests, and moves all ADM specific components into them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new productFlavor for devices using Amazon Device Messaging instead of Firebase Cloud Messaging.
Notably - if accepted, this does not require that we immediately distribute this flavor. And distribution would likely be to a separate package with the suffix
.adm. We still need to investigate the best way to fold this into thegeneralsource set, so that developers have the option to pull in general, and have our library figure out which PNS is available without downstream developers messing about with productFlavors.