proper filter for webapp and function app #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
requested review from
ChenTanyi,
xseeseesee and
yaohaizh
as code owners
ChenTanyi
approved these changes
Mar 5, 2020
ChenTanyi
reviewed
Mar 5, 2020
| @@ -58,7 +56,12 @@ public override async Task<IPagedCollection<IFunctionApp>> ListAsync(bool loadAl | |||
| Inner.ListNextAsync, | |||
| async (inner, cancellation) => await PopulateModelAsync(inner, cancellation), | |||
| loadAllPages, cancellationToken); | |||
| return PagedCollection<IFunctionApp, SiteInner>.CreateFromEnumerable(collection.Where(w => "functionapp".Equals(w.Inner.Kind, StringComparison.OrdinalIgnoreCase))); | |||
| return PagedCollection<IFunctionApp, SiteInner>.CreateFromEnumerable(collection.Where(w => w.Inner.Kind != null && w.Inner.Kind.Split(new char[] { ',' }).Contains("functionapp"))); | |||
There was a problem hiding this comment.
Not sure why we remove StringComparison.OrdinalIgnoreCase here
There was a problem hiding this comment.
Thanks for point this out. I should use FilterFunctionApp uniformly.
For ignoreCase, I will add ToLower before Split as protection, though it should not happen in live.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from sev3 ICM
fix #992