Skip to content

Update tests for azure-functions EventHub triggers #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2019
Merged

Update tests for azure-functions EventHub triggers #592

merged 3 commits into from
Dec 12, 2019

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Dec 10, 2019 •
edited
Loading

Depends On

Azure/azure-functions-python-library#32

Issue

#589

Summary

Add test scenarios for function using cardinality=many and List[func.EventHubEvent] as parameter type annotation

@Hazhzeng Hazhzeng changed the title Update tests for azure-functions 1.0.6 Update tests for azure-functions EventHub triggers Dec 11, 2019
@Hazhzeng Hazhzeng force-pushed the hazeng-pr-eventhub branch 2 times, most recently from 2c9f7f2 to 9f7603c Compare December 11, 2019 19:16
ankitkumarr
ankitkumarr approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@ankitkumarr ankitkumarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably add a failure test for List[string] or something. But will leave that up to you.

@Hazhzeng Hazhzeng merged commit dbca168 into dev Dec 12, 2019
@Hazhzeng Hazhzeng deleted the hazeng-pr-eventhub branch January 28, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitkumarr ankitkumarr ankitkumarr approved these changes

@maiqbal11 maiqbal11 Awaiting requested review from maiqbal11

@balag0 balag0 Awaiting requested review from balag0

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hazhzeng @ankitkumarr