Updating the dependencies and build pipelines to support Arm64 macOS #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
requested review from
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #1267 +/- ##
===========================================
- Coverage 83.98% 31.98% -52.00%
===========================================
Files 34 34
Lines 1904 1904
Branches 366 366
===========================================
- Hits 1599 609 -990
- Misses 234 1294 +1060
+ Partials 71 1 -70
Flags with carried forward coverage won't be shown. Click here to find out more. |
vrdmr
commented
Jun 22, 2023
azure-pipelines.yml
Outdated
| dependsOn: ['Build_WINDOWS_X64', 'Build_WINDOWS_X86', 'Build_LINUX_X64', 'Build_OSX_X64'] | ||
| condition: or(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), eq(variables['Build.SourceBranch'], 'refs/heads/dev')) | ||
| dependsOn: ['Build_WINDOWS_X64', 'Build_WINDOWS_X86', 'Build_LINUX_X64', 'Build_OSX_X64', 'Build_OSX_ARM64'] | ||
| condition: or(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), eq(variables['Build.SourceBranch'], 'refs/heads/dev'), variables['GeneratePackage']) |
There was a problem hiding this comment.
Adding a new variable variables['GeneratePackage'] in the azure pipeline can trigger this job, and there is no need to play with the branch names to get it running.
gavin-aguiar
approved these changes
Jun 23, 2023
|
Consumption tests will fail for 3.9 and above as protobuf versions have changed in this PR and don't match the one in the image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #915
PR information
Quality of Code and Contribution Guidelines