Skip to content

[DNM] Release/test mac m1 #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[DNM] Release/test mac m1 #1146

wants to merge 3 commits into from

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Nov 15, 2022

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1146 (1b7fc21) into dev (832d261) will decrease coverage by 53.61%.
The diff coverage is n/a.

❗ Current head 1b7fc21 differs from pull request most recent head 1d3bc48. Consider uploading reports for the commit 1d3bc48 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1146       +/-   ##
===========================================
- Coverage   84.92%   31.30%   -53.62%     
===========================================
  Files          32       32               
  Lines        1824     1824               
  Branches      276      276               
===========================================
- Hits         1549      571      -978     
- Misses        204     1252     +1048     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.30% <ø> (-53.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
azure_functions_worker/dispatcher.py 19.17% <0.00%> (-69.69%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
azure_functions_worker/extension.py 44.95% <0.00%> (-54.13%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ocean-orrick
Copy link

Just wanted to link issue #915 to so anyone finding that issue can see that this has been worked on. Although it seems there's been no activity on the PR for a couple months now. May I inquire if there is any ETA for this fix? Or anything I might be able to do to help?

@jschwendt
Copy link

@vrdmr Thank you for putting up this PR! Would love to see this get updated and merged. Let us know if we can help in some way as we're blocked without it.

@vrdmr
Copy link
Member Author

vrdmr commented Jun 20, 2023

Closing in favor of #1267. Apologies for the delay on this.

@vrdmr vrdmr closed this Jun 20, 2023
@vrdmr vrdmr deleted the release/test-mac-m1 branch October 13, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants