Skip to content

Commit 9ae1d62

Browse files
authored
App Settings Logs formatting fixes (#1387)
* added space and delimiter for parsing * updated test * flake issues
1 parent 0337cb7 commit 9ae1d62

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

azure_functions_worker/dispatcher.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,9 @@ async def _handle__worker_init_request(self, request):
268268
logger.info('Received WorkerInitRequest, '
269269
'python version %s, '
270270
'worker version %s, '
271-
'request ID %s.'
272-
'App Settings state: %s.'
273-
' To enable debug level logging, please refer to '
271+
'request ID %s. '
272+
'App Settings state: %s. '
273+
'To enable debug level logging, please refer to '
274274
'https://aka.ms/python-enable-debug-logging',
275275
sys.version,
276276
VERSION,
@@ -554,9 +554,9 @@ async def _handle__function_environment_reload_request(self, request):
554554
"""
555555
try:
556556
logger.info('Received FunctionEnvironmentReloadRequest, '
557-
'request ID: %s,'
558-
'App Settings state: %s.'
559-
' To enable debug level logging, please refer to '
557+
'request ID: %s, '
558+
'App Settings state: %s. '
559+
'To enable debug level logging, please refer to '
560560
'https://aka.ms/python-enable-debug-logging',
561561
self.request_id,
562562
get_python_appsetting_state())

azure_functions_worker/utils/app_setting_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def get_python_appsetting_state():
2424
FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED]
2525

2626
app_setting_states = "".join(
27-
f"{app_setting}: {current_vars[app_setting]} "
27+
f"{app_setting}: {current_vars[app_setting]} | "
2828
for app_setting in python_specific_settings
2929
if app_setting in current_vars
3030
)
@@ -38,6 +38,6 @@ def get_python_appsetting_state():
3838
else:
3939
app_setting_states += \
4040
(f"{PYTHON_ENABLE_WORKER_EXTENSIONS}: "
41-
f"{str(PYTHON_ENABLE_WORKER_EXTENSIONS_DEFAULT)} ")
41+
f"{str(PYTHON_ENABLE_WORKER_EXTENSIONS_DEFAULT)}")
4242

4343
return app_setting_states

tests/unittests/test_app_setting_manager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ async def test_initialize_worker_logging(self):
8888

8989
def test_get_python_appsetting_state(self):
9090
app_setting_state = get_python_appsetting_state()
91-
self.assertIn("PYTHON_THREADPOOL_THREAD_COUNT: 20 ", app_setting_state)
92-
self.assertIn("PYTHON_ENABLE_DEBUG_LOGGING: 1 ", app_setting_state)
91+
self.assertIn("PYTHON_THREADPOOL_THREAD_COUNT: 20 | ",
92+
app_setting_state)
93+
self.assertIn("PYTHON_ENABLE_DEBUG_LOGGING: 1 | ", app_setting_state)
9394
self.assertIn("PYTHON_ENABLE_WORKER_EXTENSIONS: ", app_setting_state)

0 commit comments

Comments
 (0)