Skip to content

Commit 4332695

Browse files
authored
Fix single event e2e tests in eventhub (#593)
* Fix eventhub e2e test should use same event hub * Remove retry catch in event hub e2e tests
1 parent dca12dd commit 4332695

File tree

4 files changed

+28
-50
lines changed

4 files changed

+28
-50
lines changed

tests/endtoend/eventhub_functions/eventhub_output/function.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"type": "eventHub",
1212
"name": "event",
1313
"direction": "out",
14-
"eventHubName": "python-worker-ci",
14+
"eventHubName": "python-worker-ci-eventhub-one",
1515
"connection": "AzureWebJobsEventHubConnectionString"
1616
},
1717
{

tests/endtoend/eventhub_functions/eventhub_trigger/function.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"type": "eventHubTrigger",
77
"name": "event",
88
"direction": "in",
9-
"eventHubName": "python-worker-eventhub-ci-linux",
9+
"eventHubName": "python-worker-ci-eventhub-one",
1010
"connection": "AzureWebJobsEventHubConnectionString"
1111
},
1212
{

tests/endtoend/test_eventhub_batch_functions.py

Lines changed: 17 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_eventhub_multiple(self):
2323
self._set_table_partition_key(partition_key)
2424

2525
# wait for host to restart after change
26-
time.sleep(1)
26+
time.sleep(5)
2727

2828
docs = []
2929
for i in range(NUM_EVENTS):
@@ -34,35 +34,25 @@ def test_eventhub_multiple(self):
3434
data=json.dumps(docs))
3535
self.assertEqual(r.status_code, 200)
3636

37-
max_retries = 30
38-
3937
row_keys = [str(i) for i in range(NUM_EVENTS)]
4038
seen = [False] * NUM_EVENTS
4139
row_keys_seen = dict(zip(row_keys, seen))
42-
for try_no in range(max_retries):
43-
# Allow trigger to fire.
44-
time.sleep(2)
45-
46-
try:
47-
r = self.webhost.request('GET',
48-
'get_eventhub_batch_triggered')
49-
self.assertEqual(r.status_code, 200)
50-
entries = r.json()
51-
for entry in entries:
52-
self.assertEqual(entry['PartitionKey'], partition_key)
53-
row_key = entry['RowKey']
54-
row_keys_seen[row_key] = True
55-
56-
self.assertDictEqual(all_row_keys_seen, row_keys_seen)
57-
58-
except AssertionError as e:
59-
if try_no == max_retries - 1:
60-
self._cleanup(old_partition_key)
61-
raise
62-
else:
63-
break
64-
65-
self._cleanup(old_partition_key)
40+
41+
# Allow trigger to fire.
42+
time.sleep(5)
43+
44+
try:
45+
r = self.webhost.request('GET', 'get_eventhub_batch_triggered')
46+
self.assertEqual(r.status_code, 200)
47+
entries = r.json()
48+
for entry in entries:
49+
self.assertEqual(entry['PartitionKey'], partition_key)
50+
row_key = entry['RowKey']
51+
row_keys_seen[row_key] = True
52+
53+
self.assertDictEqual(all_row_keys_seen, row_keys_seen)
54+
finally:
55+
self._cleanup(old_partition_key)
6656

6757
def _cleanup(self, old_partition_key):
6858
self._set_table_partition_key(old_partition_key)

tests/endtoend/test_eventhub_functions.py

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,12 @@ def test_eventhub_trigger(self):
2020
self.assertEqual(r.status_code, 200)
2121
self.assertEqual(r.text, 'OK')
2222

23-
max_retries = 30
24-
25-
for try_no in range(max_retries):
26-
# Allow trigger to fire.
27-
time.sleep(2)
28-
29-
try:
30-
# Check that the trigger has fired.
31-
r = self.webhost.request('GET', 'get_eventhub_triggered')
32-
self.assertEqual(r.status_code, 200)
33-
response = r.json()
34-
35-
self.assertEqual(
36-
response,
37-
doc
38-
)
39-
except AssertionError as e:
40-
if try_no == max_retries - 1:
41-
raise
42-
else:
43-
break
23+
# Allow trigger to fire.
24+
time.sleep(5)
25+
26+
# Check that the trigger has fired.
27+
r = self.webhost.request('GET', 'get_eventhub_triggered')
28+
self.assertEqual(r.status_code, 200)
29+
response = r.json()
30+
31+
self.assertEqual(response, doc)

0 commit comments

Comments
 (0)