Document that grace_period is not used in the InvocationCancel message #82

liliankasem · web-flow · commit ffbd3ddb07c4 · 2022-06-21T10:33:58.000-07:00
diff --git a/src/proto/FunctionRpc.proto b/src/proto/FunctionRpc.proto
@@ -397,8 +397,8 @@ message InvocationCancel {
   // Unique id for invocation
   string invocation_id = 2;
 
-  // Time period before force shutdown
-  google.protobuf.Duration grace_period = 1; // could also use absolute time
+  // PROPERTY NOT USED
+  google.protobuf.Duration grace_period = 1;
 }
 
 // Worker responds with status of Invocation

Original file line number	Diff line number	Diff line change
`@@ -397,8 +397,8 @@ message InvocationCancel {`
`397`	`397`	`// Unique id for invocation`
`398`	`398`	`string invocation_id = 2;`
`399`	`399`
`400`		`- // Time period before force shutdown`
`401`		`- google.protobuf.Duration grace_period = 1; // could also use absolute time`
	`400`	`+ // PROPERTY NOT USED`
	`401`	`+ google.protobuf.Duration grace_period = 1;`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`// Worker responds with status of Invocation`