Sending command line args with functions- prefix to prevent conflicts #9514

kshyju · 2023-09-07T18:12:46Z

During initial testing, we identified 3 language workers were not able to handle the extra/new command line arguments sent to them. Fixed those on the language worker sides and host was updated to consume the new version of language worker nuget package with the fix.

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes should not be added to the release notes for the next release
- Otherwise: I've added my notes to release_notes.md
My changes do not need to be backported to a previous version
- Otherwise: Backport tracked by issue/PR #issue_or_pr
My changes do not require diagnostic events changes
- Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
I have added all required tests (Unit tests, E2E tests)

src/WebJobs.Script/Workers/Rpc/RpcWorkerContext.cs

Francisco-Gamino

@kshyju -- The code change LGTM.

Regarding the old command arguments, should we create a work item to remove support for these (host, port, workerId, requestId, and grpcMaxMessageLength) in the future? IMHO, the language workers should only use the new command line arguments going forward.

kshyju · 2023-10-02T18:42:38Z

@kshyju -- The code change LGTM.

Regarding the old command arguments, should we create a work item to remove support for these (host, port, workerId, requestId, and grpcMaxMessageLength) in the future? IMHO, the language workers should only use the new command line arguments going forward.

Yes, If the language worker is deployed with a host version, then please consider updating the language worker to remove reading the old params).

Francisco-Gamino · 2023-10-02T20:31:29Z

@kshyju -- The code change LGTM.
Regarding the old command arguments, should we create a work item to remove support for these (host, port, workerId, requestId, and grpcMaxMessageLength) in the future? IMHO, the language workers should only use the new command line arguments going forward.

Yes, If the language worker is deployed with a host version, then please consider updating the language worker to remove reading the old params).

@kshyju -- I was also asking about removing support for the old command line arguments from the Functions Host. Thoughts?

kshyju · 2023-10-05T22:53:20Z

Functions

Dotnet isolated apps which were deployed with older version of .net worker nuget packages (which does not have the code to read the new args) will fail. So It is not safe for us to delete the old args at this point.

…#9514) * Sending a second copy of command line args with "FUNCTIONS_" prefix * Cleanup * Sending a second copy of command line args with "FUNCTIONS_" prefix * switched to functions- prefix * Removed duplicate port from functions_uri * Switching to kebab case for the new args * Update test * Update native placeholder package to handle new args * Update release notes.

* Updating patch version * Sending command line args with functions- prefix to prevent conflicts (#9514) * Sending a second copy of command line args with "FUNCTIONS_" prefix * Cleanup * Sending a second copy of command line args with "FUNCTIONS_" prefix * switched to functions- prefix * Removed duplicate port from functions_uri * Switching to kebab case for the new args * Update test * Update native placeholder package to handle new args * Update release notes. * Limit dotnet-isolated specialization to 64 bit host process (#9553) * Skipping native placeholder specialization if host is not 64 bit process * formatting linting fix * Stylecop fix. * fix indentation * Adding E2E test. * Improving log message. * Switch from LogDebug to LogInformation * Fix tests to reflect logging changes * Logging with EventId * Logging using an event name * Updated release notes after rebase merge * Handling env reload response from native placeholder for failure case. (#9602) * Handling env reload response from native placeholder for failure case. * Almost working except one test needs cleanup * Cleanup * Cleanup * Fixing Worker.Extensions.Http package version to align with Http.AspNetCore package. * Logging error as it is received from the worker. * DotNetIsolatedNativeHost package to 1.0.2 * Inlining a variable (Reverting to previous version) * Updating release notes for 4.27.5 * Update PowerShell Language Workers 7.0 (to version 4.0.2973), 7.2 (to version 4.0.2974), and 7.4 (to version 4.0.2975) (#9528) * Upgrade PowerShell language worker 7.4 to 4.0.2975 * Upgrade PowerShell language worker 7.2 to 4.0.2974 * Upgrade PowerShell language worker 7.0 to 4.0.2973 * Update release notes * Update Java Worker Version to 2.13.0 (#9544) * Update Java Worker Version to 2.13.0 * Update release_notes.md for Java worker --------- Co-authored-by: AzureFunctionsJava <funcdisc@microsoft.com> --------- Co-authored-by: azfuncgh <azfuncgh@github.com> Co-authored-by: Shyju Krishnankutty <connectshyju@gmail.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Shreyas Gopalakrishna <11889130+shreyas-gopalakrishna@users.noreply.github.com> Co-authored-by: AzureFunctionsJava <funcdisc@microsoft.com>

Francisco-Gamino mentioned this pull request Sep 8, 2023

Update language worker to support parsing command-line arguments prefix with functions-<argumentname> Azure/azure-functions-powershell-worker#992

Closed

kshyju force-pushed the shkr/wrkr_1547_new_cmdnline_args branch 3 times, most recently from 6132996 to a0536a0 Compare September 18, 2023 22:27

kshyju force-pushed the shkr/wrkr_1547_new_cmdnline_args branch from a0536a0 to b4060df Compare September 21, 2023 14:36

kshyju marked this pull request as ready for review September 21, 2023 15:28

kshyju requested a review from a team as a code owner September 21, 2023 15:28

liliankasem approved these changes Sep 26, 2023

View reviewed changes

kshyju force-pushed the shkr/wrkr_1547_new_cmdnline_args branch from b4060df to b15033f Compare September 26, 2023 20:08

surgupta-msft reviewed Sep 28, 2023

View reviewed changes

src/WebJobs.Script/Workers/Rpc/RpcWorkerContext.cs Show resolved Hide resolved

surgupta-msft approved these changes Sep 28, 2023

View reviewed changes

kshyju mentioned this pull request Sep 29, 2023

Updating Microsoft.Azure.Functions.DotNetIsolatedNativeHost package to 1.0.0 #9582

Closed

8 tasks

kshyju added 8 commits September 29, 2023 13:54

Sending a second copy of command line args with "FUNCTIONS_" prefix

869110b

Cleanup

a8a5021

Sending a second copy of command line args with "FUNCTIONS_" prefix

ad8423c

switched to functions- prefix

10d27cb

Removed duplicate port from functions_uri

f62f567

Switching to kebab case for the new args

af2c41c

Update test

39499e1

Update native placeholder package to handle new args

514049c

kshyju force-pushed the shkr/wrkr_1547_new_cmdnline_args branch from 1235972 to 514049c Compare September 29, 2023 20:54

kshyju requested review from vrdmr, ejizba, shreyas-gopalakrishna, Francisco-Gamino and gavin-aguiar October 2, 2023 18:14

Francisco-Gamino approved these changes Oct 2, 2023

View reviewed changes

Update release notes.

6b0df55

kshyju merged commit f4fa1b1 into dev Oct 2, 2023

kshyju deleted the shkr/wrkr_1547_new_cmdnline_args branch October 2, 2023 19:53

kshyju mentioned this pull request Oct 6, 2023

Update Python Worker Version to 4.14.0 #9592

Closed

8 tasks

VpOfEngineering mentioned this pull request Oct 12, 2023

4.27.5 hotfix #9609

Merged

8 tasks

ejizba mentioned this pull request Oct 12, 2023

Use new worker args Azure/azure-functions-nodejs-worker#719

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sending command line args with functions- prefix to prevent conflicts #9514

Sending command line args with functions- prefix to prevent conflicts #9514

Uh oh!

kshyju commented Sep 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

Francisco-Gamino left a comment •

edited

Loading

Uh oh!

kshyju commented Oct 2, 2023

Uh oh!

Francisco-Gamino commented Oct 2, 2023

Uh oh!

kshyju commented Oct 5, 2023 •

edited

Loading

Uh oh!

Uh oh!

Sending command line args with functions- prefix to prevent conflicts #9514

Sending command line args with functions- prefix to prevent conflicts #9514

Uh oh!

Conversation

kshyju commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Uh oh!

Uh oh!

Francisco-Gamino left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kshyju commented Oct 2, 2023

Uh oh!

Francisco-Gamino commented Oct 2, 2023

Uh oh!

kshyju commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kshyju commented Sep 7, 2023 •

edited

Loading

Francisco-Gamino left a comment •

edited

Loading

kshyju commented Oct 5, 2023 •

edited

Loading