Added new GRPC message types for worker indexing, along with relevant functions and tests #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functions into GrpcWorkerChannel to handle sending requests and receiving responses form the worker. Added test to check functionality of new worker channel functions.
brettsam
reviewed
Jul 13, 2021
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Outdated
Show resolved
Hide resolved
…GRPC message types based on Brett's feedback Also changed some debug message descriptiveness based on the feedback too.
…own by the worker.
brettsam
reviewed
Jul 14, 2021
Added a debug log statement for when the worker indexing result for a function is a failure.
brettsam
previously approved these changes
Jul 15, 2021
Change log statement to a `LogError`
brettsam
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf needs to support sending and receiving worker metadata requests/responses
This PR adds the new worker indexing GRPC message types to the protobuf. It also adds some functions into GrpcWorkerChannel.cs to send/receive the metadata requests and responses, along with a test to check this sending and receiving functionality.
Resolves #7513 and #7514
Pull request checklist
release_notes.md