Implement changes needed in the Host to decouple workers from the Host release #11111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surgupta-msft
commented
Jun 9, 2025
| @@ -144,30 +176,16 @@ internal void AddProvider(string workerDir) | |||
|
|
|||
| _logger.LogDebug("Found worker config: {workerConfigPath}", workerConfigPath); | |||
|
|
|||
| var workerConfig = GetWorkerConfigJsonElement(workerConfigPath); | |||
There was a problem hiding this comment.
No change in logic for this line. Just moved the method GetWorkerConfigJsonElement() to class WorkerConfigurationHelper
surgupta-msft
commented
Jun 9, 2025
| @@ -144,30 +176,16 @@ internal void AddProvider(string workerDir) | |||
|
|
|||
| _logger.LogDebug("Found worker config: {workerConfigPath}", workerConfigPath); | |||
|
|
|||
| var workerConfig = GetWorkerConfigJsonElement(workerConfigPath); | |||
| var workerDescriptionElement = workerConfig.GetProperty(WorkerConstants.WorkerDescription); | |||
There was a problem hiding this comment.
All these lines (148-150 and 152-170) are moved to a method WorkerConfigurationHelper.GetWorkerDescription()
surgupta-msft
commented
Jun 9, 2025
| @@ -213,61 +231,6 @@ internal void AddProvider(string workerDir) | |||
| } | |||
| } | |||
|
|
|||
| private static JsonElement GetWorkerConfigJsonElement(string workerConfigPath) | |||
There was a problem hiding this comment.
These methods are also moved to class WorkerConfigurationHelper as we will need to call these methods from class WorkerConfigurationResolver as part of compatibility check.
surgupta-msft
commented
Jun 9, 2025
| namespace Microsoft.Azure.WebJobs.Script.Workers.Rpc.Configuration | ||
| { | ||
| internal static class WorkerConfigurationHelper | ||
| { |
There was a problem hiding this comment.
All the methods in this class are taken from RPCWorkerConfigFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10944
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information
This PR implements initial changes to decouple language workers from the Host release payload.
Backlog issues - Link
Design doc - Link
Flows covered in this PR -
WorkerConfigurationResolverand passes probingPaths to that. Sends the instance ofWorkerConfigurationResolverwhen creating an instance ofRPCWorkerConfigFactoryGetWorkerConfigs()method ofWorkerConfigurationResolver, otherwise look for worker configs within Host.WorkerConfigurationHelper.csto enable reusing of workers profile evaluation logic.FeatureFlagEnableWorkerProbingPathsandFeatureFlagDisableWorkerProbingPathsto enable or disable worker probing paths.Note: The decoupling workers flow is disabled by default in this PR. We will enable the flow after completing other relevant backlog items which will be included in follow-up PRs.