Skip to content

Support logicapps pwsh version setting #11105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Support logicapps pwsh version setting #11105

merged 3 commits into from
Jun 10, 2025

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Jun 4, 2025

Issue describing the changes in this PR

resolves #11067

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Special cases the env var LOGIC_APPS_POWERSHELL_VERSION when resolving worker.config.json for powershell. Allows this setting to take precedence over FUNCTIONS_WORKER_RUNTIME_VERSION. Logic Apps is a multi-language environment, and so it needs an env var specific to powershell and cannot rely on the generic FUNCTIONS_WORKER_RUNTIME_VERSION

@jviau jviau requested a review from a team as a code owner June 4, 2025 21:22
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jviau .

I'll flag this so we can remove special casing as part of the future refactoring work.

@jviau jviau merged commit 142c288 into in-proc Jun 10, 2025
9 checks passed
@jviau jviau deleted the jviau/la-pwsh-setting branch June 10, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants