Upgrade E2E tests to Core Tools v4.0.7317 #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatoliB
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the E2E test script to use the officially published Azure Functions Core Tools v4.0.7317 and removes support for pulling builds from the internal integration tests feed.
- Deprecates and ignores the
UseCoreToolsBuildFromIntegrationTestsswitch (with a warning). - Introduces a hard-coded
CORE_TOOLS_VERSIONand updates the download URL to the GitHub release for v4.0.7317.
Comments suppressed due to low confidence (1)
test/E2E/Start-E2ETest.ps1:63
- The deprecation of the
UseCoreToolsBuildFromIntegrationTestsswitch should be added to the script’s Param block help so users see it’s ignored without running the script.
if ($UseCoreToolsBuildFromIntegrationTests.IsPresent)
andystaples
previously approved these changes
Jun 6, 2025
andystaples
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to upgrade to PowerShell 7.4 and .NET 8, I discovered that Core Tools builds are not published to the same internal location anymore. As a result, the E2E tests were using a very old version of Core Tools, which led to test failures.
This PR makes the E2E tests use Core Tools v4.0.7317 (the latest officially published version), and it also removes the
UseCoreToolsBuildFromIntegrationTestssupport.In the future, we may want to find another way of retrieving the latest version, especially for the purposes of internal integration tests. However, I believe public tests on GitHub should rely on officially published Core Tools versions, and we should upgrade this dependency the same way as we upgrade other dependencies: with an explicit version bump.