Override new "base" Terminate API #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
requested changes
May 23, 2024
src/Worker.Extensions.DurableTask/FunctionsDurableTaskClient.cs
Outdated
Show resolved
Hide resolved
davidmrdavid
commented
May 23, 2024
| using Microsoft.Azure.Functions.Worker.Extensions.Abstractions; | ||
|
|
||
| // TODO: Find a way to generate this dynamically at build-time | ||
| [assembly: ExtensionInformation("Microsoft.Azure.WebJobs.Extensions.DurableTask", "2.13.3")] | ||
| [assembly: InternalsVisibleTo("Worker.Extensions.DurableTask.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100cd1dabd5a893b40e75dc901fe7293db4a3caf9cd4d3e3ed6178d49cd476969abe74a9e0b7f4a0bb15edca48758155d35a4f05e6e852fff1b319d103b39ba04acbadd278c2753627c95e1f6f6582425374b92f51cca3deb0d2aab9de3ecda7753900a31f70a236f163006beefffe282888f85e3c76d1205ec7dfef7fa472a17b1")] |
There was a problem hiding this comment.
So that internal classes can be tested in the tests project. This is a standard pattern, and we use it for the DF WebJobs Extension tests afaik.
davidmrdavid
commented
May 23, 2024
Comment on lines
+23
to
+24
| string readerString = reader.GetString() ?? string.Empty; | ||
| return new HttpMethod(readerString); |
There was a problem hiding this comment.
There was a small warning that reader.GetString() might return null. So I added this to make sure the method was well typed.
jviau
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #2802
The PR above made the
FunctionsDurableTaskClientoverride new overloads fromDurableTaskClientwhich were causing issues as reported here: microsoft/durabletask-dotnet#282 (comment)Seems we missed the
TerminateInstanceAsyncAPI in the PR above, so this PR adds it.This PR also adds what appears to be the first set of unit tests for the .NET isolated worker extension. In it, we're testing against this particular exception: that the
TerminateInstanceAsyncAPI can be invoked without triggering exceptions. I tested with and without the code change and confirmed that the test is fails without the change, and passes with it.Note: the new test project I added won't run as part of the CI automatically. I think to do that, I need to create a new ADO pipeline. Given that we're migrating our CI to a different ADO organization, now may not be the right time to add it either, so I'd like to do that in a different PR.
Issue describing the changes in this PR
resolves microsoft/durabletask-dotnet#282 (comment)
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.cs