-
Notifications
You must be signed in to change notification settings - Fork 201
update xunit to current stable #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates xunit testing framework packages across six test projects to newer versions.
- xunit framework updated from version 2.9.0 to 2.9.3
- xunit.runner.visualstudio updated from version 2.8.2 to 3.1.5 (major version bump)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/TestUtility/TestUtility.csproj | Updates xunit package to version 2.9.3 |
| test/Sdk.Generator.Tests/Sdk.Generator.Tests.csproj | Updates xunit to 2.9.3 and xunit.runner.visualstudio to 3.1.5 |
| test/Sdk.E2ETests/Sdk.E2ETests.csproj | Updates xunit to 2.9.3 and xunit.runner.visualstudio to 3.1.5 |
| test/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests.csproj | Updates xunit to 2.9.3 and xunit.runner.visualstudio to 3.1.5 |
| test/DotNetWorkerTests/DotNetWorkerTests.csproj | Updates xunit to 2.9.3 and xunit.runner.visualstudio to 3.1.5 |
| test/DotNetWorker.OpenTelemetry.Tests/DotNetWorker.OpenTelemetry.Tests.csproj | Updates xunit to 2.9.3 and xunit.runner.visualstudio to 3.1.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fabiocav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonCropp thank you for the contributions!
Can you please update the PRs with the dependency updates with more details, including motivations to make sure we have that documented and understand if any of the updates need to be prioritized (if they're impacting any of your scenarios).
Can you also please ensure appropriate release_notes.md (where appropriate) with the changes?
they are prep work for this #2691 (comment)
none need to prioritized
development only changes should not appear in release notes since they have no impact on consumers of the project |
|
/azp run dotnet-worker.public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@SimonCropp looks like there is a package downgrade issue in this change. |
No description provided.