Address copilot review

Author: jviau

src/Azure.Functions.Sdk/ExceptionExtensions.cs

@@ -12,22 +12,35 @@ internal static class ExceptionExtensions
     /// </summary>
     /// <param name="exception">The exception to check.</param>
     /// <returns></returns>
-    public static bool IsFatal(this Exception exception)
+    public static bool IsFatal(this Exception? exception)
     {
-        Throw.IfNull(exception);
-        while (exception != null)
+        while (exception is not null)
         {
             if (exception
                 is (OutOfMemoryException and not InsufficientMemoryException)
-                or ThreadAbortException
-                or AccessViolationException
-                or SEHException
-                or StackOverflowException)
+                or AppDomainUnloadedException
+                or BadImageFormatException
+                or CannotUnloadAppDomainException
+                or InvalidProgramException
+                or AccessViolationException)
             {
                 return true;
             }
 
-            exception = exception.InnerException;
+            if (exception is AggregateException aggregate)
+            {
+                foreach (Exception inner in aggregate.InnerExceptions)
+                {
+                    if (inner.IsFatal())
+                    {
+                        return true;
+                    }
+                }
+            }
+            else
+            {
+                exception = exception.InnerException;
+            }
         }
 
         return false;

src/Azure.Functions.Sdk/FunctionsAssemblyResolver.cs

@@ -11,18 +11,18 @@ public class FunctionsAssemblyResolver : DefaultAssemblyResolver
     private static readonly ImmutableHashSet<string> TrustedPlatformAssemblies
         = GetTrustedPlatformAssemblies();
 
-    private static ImmutableHashSet<string> GetTrustedPlatformAssemblies()
-    {
-        var data = AppContext.GetData("TRUSTED_PLATFORM_ASSEMBLIES");
-        return data.ToString().Split(Path.PathSeparator)
-            .ToImmutableHashSet(StringComparer.OrdinalIgnoreCase);
-    }
-
     public override AssemblyDefinition? Resolve(AssemblyNameReference name)
     {
         // As soon as we get to a TPA we can stop. This helps prevent the odd circular reference
         // with type forwarders as well.
         AssemblyDefinition assemblyDef = base.Resolve(name);
         return TrustedPlatformAssemblies.Contains(assemblyDef.MainModule.FileName) ? null : assemblyDef;
     }
+
+    private static ImmutableHashSet<string> GetTrustedPlatformAssemblies()
+    {
+        object data = AppContext.GetData("TRUSTED_PLATFORM_ASSEMBLIES");
+        return data is null ? [] : data.ToString().Split(Path.PathSeparator)
+            .ToImmutableHashSet(StringComparer.OrdinalIgnoreCase);
+    }
 }