adding python313 dockerfile locally #4611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manikantanallagatla
approved these changes
Aug 25, 2025
liliankasem
reviewed
Aug 29, 2025
liliankasem
reviewed
Aug 29, 2025
bmanjwani
changed the title
liliankasem
reviewed
Sep 30, 2025
| { | ||
| switch (imageName) | ||
| { | ||
| case "local/python3.13-buildenv": |
There was a problem hiding this comment.
Can use the const here: LinuxPython313ImageAmd64
liliankasem
reviewed
Sep 30, 2025
| // creating temp folder for Dockerfile | ||
| string imageTag = dockerImage.Replace("local/", string.Empty).Replace(":", "-"); | ||
| string tempDir = Path.Combine(Path.GetTempPath(), $"{imageTag}-docker"); | ||
| Directory.CreateDirectory(tempDir); |
There was a problem hiding this comment.
Can use CreateDirectory from FileSystemHelpers
liliankasem
reviewed
Sep 30, 2025
| return imageName.StartsWith("local/", StringComparison.OrdinalIgnoreCase); | ||
| } | ||
|
|
||
| private static Task<string> GetDockerfileForImage(string imageName) |
There was a problem hiding this comment.
Can we use GetDockerInitFileContent instead? And update
case 13:
return StaticResources.DockerfilePython313;
to
case 13:
return StaticResources.DockerfilePython313buildenv;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
Additional PR information