This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Os Upgrade Feature #411
Merged
Os Upgrade Feature #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamverma-ms
force-pushed
the
OsUpgrade
branch
from
59831a5 to
bc0f1e7
Compare
singhabh27
reviewed
Aug 23, 2023
| #start the migration | ||
| if ([string]::IsNullOrEmpty($TurnOff_SrcServer) -or ($TurnOff_SrcServer -eq 'N') -or ($TurnOff_SrcServer -eq 'No')){ | ||
| #we are defaulting to this if Turn off Source Server is not mentioned | ||
| $MigrateJob = Start-AzMigrateServerMigration -InputObject $ReplicatingServermachine | ||
| $MigrateJob = Start-AzMigrateServerMigration -InputObject $ReplicatingServermachine -OsUpgradeVersion $osUpgradeVersion |
There was a problem hiding this comment.
We should pass $osUpgradeVersion only if it is not null or empty.
| $reportItem.AdditionalInformation = "OS_VERSION_UPGRADE is not mentioned for: '$($sourceMachineName)'" | ||
| } | ||
|
|
||
| $TestMigrationJob = Start-AzMigrateTestMigration -InputObject $ReplicatingServermachine -TestNetworkID $Target_VNet.Id -OsUpgradeVersion $osUpgradeVersion |
There was a problem hiding this comment.
$osUpgradeVersion should not be passed always.
singhabh27
reviewed
Aug 25, 2023
| @@ -235,6 +235,76 @@ Function ProcessItemImpl($processor, $csvItem, $reportItem) { | |||
| } | |||
| #End Code for Target Subscription | |||
|
|
|||
| $targetDiskName = $csvItem.UPDATED_TARGET_DISK_NAME | |||
There was a problem hiding this comment.
Remove custom resource naming changes from this PR.
singhabh27
reviewed
Aug 28, 2023
...e-at-scale-vmware-agentles/Agentless VMware automation/AzMigrate_UpdateMachineProperties.ps1
Outdated
Show resolved
Hide resolved
singhabh27
reviewed
Aug 28, 2023
...e-at-scale-vmware-agentles/Agentless VMware automation/AzMigrate_UpdateMachineProperties.ps1
Outdated
Show resolved
Hide resolved
singhabh27
reviewed
Aug 28, 2023
...igrate-at-scale-vmware-agentles/Agentless VMware automation/AzMigrate_StartTestMigration.ps1
Outdated
Show resolved
Hide resolved
singhabh27
reviewed
Aug 28, 2023
...te/migrate-at-scale-vmware-agentles/Agentless VMware automation/AzMigrate_StartMigration.ps1
Outdated
Show resolved
Hide resolved
|
#sign-off |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Az version:
10.0.1