Address some comments

Author: akharit

azure/datalake/store/core.py

@@ -43,7 +43,7 @@ class AzureDLFileSystem(object):
     Parameters
     ----------
     store_name: str ("")
-        Store name to connect to.
+        Store name to connect to. If not supplied, we use environment variable azure_data_lake_store_name
     token_credential: credentials object
         When setting up a new connection, this contains the authorization
         credentials. Use Azure Identity to get this or define an implementation of azure.core.credentials.TokenCredential
@@ -61,10 +61,9 @@ class AzureDLFileSystem(object):
     """
     _singleton = [None]
 
-    def __init__(self, token_credential=None, per_call_timeout_seconds=60, **kwargs):
+    def __init__(self, token_credential=None, **kwargs):
         self.token_credential = token_credential
         self.kwargs = kwargs
-        self.per_call_timeout_seconds = per_call_timeout_seconds
         self.connect()
         self.dirs = {}
         self._emptyDirs = []
@@ -83,7 +82,7 @@ def connect(self):
         """
         Establish connection object.
         """
-        self.azure = DatalakeRESTInterface(token_credential=self.token_credential, req_timeout_s=self.per_call_timeout_seconds, **self.kwargs)
+        self.azure = DatalakeRESTInterface(token_credential=self.token_credential, **self.kwargs)
         self.token_credential = self.azure.token_credential
 
     def __setstate__(self, state):

azure/datalake/store/lib.py

@@ -119,8 +119,7 @@ class DatalakeRESTInterface:
         'REMOVEDEFAULTACL': ('put', set(), set())
     }
 
-    def __init__(self, store_name=default_store, token_credential=None,
-                 url_suffix=default_adls_suffix, api_version='2018-09-01', req_timeout_s=60, scopes=None):
+    def __init__(self, store_name=default_store, token_credential=None, scopes=None, url_suffix=default_adls_suffix, **kwargs):
         # in the case where an empty string is passed for the url suffix, it must be replaced with the default.
         url_suffix = url_suffix or default_adls_suffix
         self.local = threading.local()
@@ -130,7 +129,9 @@ def __init__(self, store_name=default_store, token_credential=None,
 
         # There is a case where the user can opt to exclude an API version, in which case
         # the service itself decides on the API version to use (it's default).
-        self.api_version = api_version or None
+        self.api_version = kwargs.pop('api_version', '2018-09-01')
+        self.req_timeout_s = kwargs.pop('req_timeout_s', 60)
+
         self.url = 'https://%s.%s/' % (store_name, url_suffix)
 
         self.webhdfs = 'webhdfs/v1/'
@@ -140,7 +141,6 @@ def __init__(self, store_name=default_store, token_credential=None,
             platform.platform(),
             __name__,
             __version__)
-        self.req_timeout_s = req_timeout_s
 
     def get_refreshed_bearer_token(self):
         # Check if the token is about to expire in 300 seconds and refresh it if necessary

setup.py

@@ -41,11 +41,9 @@
                                       ]),
       install_requires=[
           'cffi',
-          'requests>=2.20.0',
-          'azure-identity',
+          'requests>=2.20.0'
       ],
-      extras_require={
-      },
+      extras_require={ 'auth': ['azure-identity']},
       long_description=readme + '\n\n' + history,
       zip_safe=False,
 )