Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty error message if query parsing fails from unexpected exception. #574

Merged
merged 3 commits into from
Jul 19, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jul 19, 2019

Pull Request Template

Description

If the incorrect service interop version is loaded it can cause unexpected exceptions which then has no serializedQueryExecutionInfo. This causes the user to get an error with no message information. If there is no message is now gives a warning to verify the version and gives the original exception content.

#573 will prevent this issue in the future.
#566 fixes the empty error message, but not the root problem

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@j82w j82w added bug Something isn't working Engineering engineering improvements (CI, tests, etc.) labels Jul 19, 2019
@j82w j82w requested a review from kirillg as a code owner July 19, 2019 12:25
@j82w j82w self-assigned this Jul 19, 2019
@j82w j82w added the QUERY label Jul 19, 2019
@j82w j82w changed the title Add additional error information if parsing fails. Add additional error information if query parsing fails. Jul 19, 2019
@j82w j82w changed the title Add additional error information if query parsing fails. Fixed empty error message if query parsing fails from unexpected exception. Jul 19, 2019
@kirankumarkolli kirankumarkolli merged commit 1ccd9ec into master Jul 19, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/query_service_interop_error branch July 19, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Engineering engineering improvements (CI, tests, etc.) QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants