-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Telemetry: Fixes Operation name to follow Otel convention #4643
Merged
microsoft-github-policy-service
merged 22 commits into
master
from
users/sourabhjain/opentelemetryopsname
Sep 18, 2024
Merged
Open Telemetry: Fixes Operation name to follow Otel convention #4643
microsoft-github-policy-service
merged 22 commits into
master
from
users/sourabhjain/opentelemetryopsname
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
August 16, 2024 10:44
sourabh1007
changed the title
Open Telemetry: Fixes Operation name to open follow Otel convention
Open Telemetry: Fixes Operation name to follow Otel convention
Aug 17, 2024
sourabh1007
force-pushed
the
users/sourabhjain/opentelemetryopsname
branch
3 times, most recently
from
August 26, 2024 02:35
080f87b
to
b323d28
Compare
sourabh1007
force-pushed
the
users/sourabhjain/opentelemetryopsname
branch
from
August 26, 2024 10:11
b323d28
to
782e521
Compare
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedPartitionKeyResultSetIteratorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorIterator.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/FeedIterators/FeedIteratorInlineCore{T}.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
jcocchi
reviewed
Aug 27, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorIterator.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedPartitionKeyResultSetIteratorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryConstants.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryConstants.cs
Outdated
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/opentelemetryopsname
branch
5 times, most recently
from
September 1, 2024 01:54
7fe48e2
to
7bc86d1
Compare
sourabh1007
force-pushed
the
users/sourabhjain/opentelemetryopsname
branch
from
September 17, 2024 19:22
df8974c
to
5e31de4
Compare
FabianMeiswinkel
previously approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jcocchi
approved these changes
Sep 17, 2024
kirankumarkolli
approved these changes
Sep 18, 2024
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/opentelemetryopsname
branch
September 18, 2024 01:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #4553
db.operation.name
Batch/bulk operations:
execute_batch
execute_bulk
batch_< operation name >
bulk_< operation name > (not covered yet)
Change feed operations:
query_change_feed
Conflicts operations:
delete_conflict
query_conflicts
read_all_conflictsread_conflict
Container operations:
create_container
create_container_if_not_exists
delete_container
query_containersread_all_containersread_container
replace_container
Database operations:
create_database
create_database_if_not_exists
delete_database
query_databasesread_all_databasesEncryption key operations:
create_client_encryption_key
query_encryption_keysread_all_encryption_keysread_client_encryption_key
replace_client_encryption_key
Item operations:
create_item
delete_all_items_by_partition_key
delete_item
patch_item
query_items
read_all_itemsread_all_items_of_logical_partitionread_many_items
read_item
replace_item
upsert_item
Permission operations:
create_permission
delete_permission
query_permissionsread_all_permissionsread_permission
replace_permission
upsert_permission
Stored procedure operations:
create_stored_procedure
delete_stored_procedure
execute_stored_procedure
query_stored_proceduresread_all_stored_proceduresread_stored_procedure
replace_stored_procedure
Throughput operations:
read_throughput
replace_throughput
Trigger operations:
create_trigger
delete_trigger
query_triggersread_all_triggersread_trigger
replace_trigger
User operations:
create_user
delete_user
query_usersread_all_usersread_user
replace_user
upsert_user
User-defined function operations:
create_user_defined_function
delete_user_defined_function
query_user_defined_functionsread_all_user_defined_functions
read_user_defined_function
Batch
.bulk_
as prefix for operations