Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Fixes ServiceInterop.dll to be BinSkim compliant by adding /guard /Qspectre flags #2710

Merged
merged 6 commits into from
Sep 8, 2021

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Sep 8, 2021

This bump includes:

  • Security: Fixed ServiceInterop.dll to be BinSkim compliant by adding /guard /Qspectre flags
  • Diagnostics: Fixed memory consumption metric in Linux to match Windows unit

Closes #1724

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@ealsur ealsur changed the title Security: Fixed ServiceInterop.dll being compliant with BinSkim Security: Fixes ServiceInterop.dll being compliant with BinSkim Sep 8, 2021
@j82w j82w changed the title Security: Fixes ServiceInterop.dll being compliant with BinSkim Security: Fixes ServiceInterop.dll to be BinSkim compliant by adding /guard /Qspectre flags Sep 8, 2021
@ealsur ealsur merged commit 090af9c into master Sep 8, 2021
@ealsur ealsur deleted the users/ealsur/direct3211 branch September 8, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binskim fails on native dependencies
2 participants