-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway: Fixes gateway mode ApplySessionToken bug causes cache to always refresh #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
April 21, 2021 12:10
FabianMeiswinkel
previously approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks
…m/Azure/azure-cosmos-dotnet-v3 into users/jawilley/bug/pkRangeRefresh
kirankumarkolli
approved these changes
Apr 21, 2021
kirankumarkolli
previously approved these changes
Apr 21, 2021
ealsur
previously approved these changes
Apr 21, 2021
…ge validation is opt-in instead of default on.
j82w
changed the title
Gateway: Fixes gateway mode apply session token logic to prevent refreshing cache on every call
Gateway: Fixes gateway mode force partition key range cache refreshes on every call
Apr 21, 2021
j82w
changed the title
Gateway: Fixes gateway mode force partition key range cache refreshes on every call
Gateway: Fixes gateway mode ApplySessionToken bug causes cache to always refresh
Apr 21, 2021
ealsur
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The ApplySessionToken logic was using the
partitionKeyRangeId.ToString()
instead of the correctpartitionKeyRangeId.PartitionKeyRangeId
. This was causing the cache to always miss and force a refresh on every call.Testing:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber