Query: Adds Correlated ActivityId wiring through query and bumps Direct version #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asketagarwal
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
leminh98,
neildsh and
sboshra
as code owners
j82w
changed the title
j82w
reviewed
Apr 19, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosBasicQueryTests.cs
Show resolved
Hide resolved
j82w
reviewed
Apr 19, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosBasicQueryTests.cs
Show resolved
Hide resolved
…Azure/azure-cosmos-dotnet-v3 into users/askagarw/query-activityId
j82w
reviewed
Apr 19, 2021
…Azure/azure-cosmos-dotnet-v3 into users/askagarw/query-activityId
j82w
reviewed
Apr 20, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/SanityQueryTests.cs
Outdated
Show resolved
Hide resolved
|
Please test this end-to-end at least manually. From my understanding the CorrelatedActivityId isn't wired up properly in the Rntbd transport yet - and it would never be actually sent to the backend at least when using direct transport . This feature is only useful when the header is actually sent to the backend (and makes it into Kusto SqlQueryExecMetric table) |
…Azure/azure-cosmos-dotnet-v3 into users/askagarw/query-activityId
asketagarwal
dismissed stale reviews from j82w and kirankumarkolli
via
8b6dfc5
j82w
reviewed
Jan 20, 2022
...osmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/EndToEndTraceWriterBaselineTests.cs
Show resolved
Hide resolved
…Azure/azure-cosmos-dotnet-v3 into users/askagarw/query-activityId
…Azure/azure-cosmos-dotnet-v3 into users/askagarw/query-activityId
j82w
previously approved these changes
Jan 26, 2022
j82w
reviewed
Jan 31, 2022
asketagarwal
force-pushed
the
users/askagarw/query-activityId
branch
from
c5fb053
to
063b54a
Compare
j82w
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR enable the SDK to send a common correlated activity id to BE, which will lead to better troubleshooting.
Closing issues
closes #2391