LINQ: Adds camelCase support to GetItemLinqQueryable() as optional parameter #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asketagarwal
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Feb 16, 2021
j82w
reviewed
Feb 16, 2021
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Feb 16, 2021
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemLinqTests.cs
Show resolved
Hide resolved
j82w
previously approved these changes
Feb 16, 2021
ealsur
reviewed
Feb 16, 2021
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Feb 18, 2021
kirankumarkolli
previously approved these changes
Feb 23, 2021
kirankumarkolli
dismissed
their stale review
Khoa comment on contract needs attention.
asketagarwal
changed the title
j82w
reviewed
Feb 23, 2021
j82w
previously approved these changes
Feb 23, 2021
ealsur
previously approved these changes
Feb 23, 2021
kirankumarkolli
previously approved these changes
Feb 23, 2021
j82w
reviewed
Feb 23, 2021
Microsoft.Azure.Cosmos/src/Serializer/CosmosLinqSerializerOptions.cs
Outdated
Show resolved
Hide resolved
asketagarwal
dismissed stale reviews from kirankumarkolli, ealsur, and j82w
via
f68f22b
j82w
approved these changes
Feb 24, 2021
kirankumarkolli
approved these changes
Feb 24, 2021
|
Thanks @asketagarwal for making this change. |
|
How does this address #1936? |
|
@onionhammer I reopened it. Sorry, I got my issues mixed up and thought it was a camel case request. |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds a CosmosLinqSerializerOptions contract to GetItemLinqQueryable as an optional parameter API for converting property names to camelCase
Closing issues
To automatically close an issue: closes #1782, #1936, #2212