Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryParser: Adds / Fixes multiple arguments in IN clause #1926

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

bchong95
Copy link
Contributor

Internal QueryParser: Adds / Fixes multiple arguments in IN clause

Description

Grammar for IN clause was: binary_scalar_expression K_NOT? K_IN scalar_expression_list which only allowed for 1 argument expressions, since scalar_expression_list would match to a parenthesized scalar expression.

The fix is to add the start list and end list tokens.

Updated the baselines as appropriate.

Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit 0e0bdb7 into master Oct 19, 2020
@sboshra sboshra deleted the users/brchon/QueryParsers/Fixes branch October 19, 2020 21:47
@j82w j82w changed the title Internal QueryParser: Adds / Fixes multiple arguments in IN clause QueryParser: Adds / Fixes multiple arguments in IN clause Oct 21, 2020
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants