Internal QueryPartitionProvider: Adds Singleton QueryPartitionProvider #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es one provider per query request.
DmitriMelnikov
requested review from
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
bchong95
changed the title
bchong95
reviewed
Sep 10, 2020
bchong95
reviewed
Sep 10, 2020
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPartitionProvider.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Sep 10, 2020
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPartitionProvider.cs
Show resolved
Hide resolved
bchong95
reviewed
Sep 10, 2020
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPartitionProvider.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Sep 10, 2020
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPartitionProvider.cs
Show resolved
Hide resolved
bchong95
previously approved these changes
Sep 10, 2020
|
Nice work! Thanks for making the change :) |
ealsur
reviewed
Sep 10, 2020
ealsur
reviewed
Sep 10, 2020
j82w
reviewed
Sep 11, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Utils/MockDocumentClient.cs
Show resolved
Hide resolved
sboshra
reviewed
Sep 11, 2020
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPartitionProvider.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Sep 11, 2020
sboshra
approved these changes
Sep 11, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QueryPartitionProvider is an expensive object since it requires initialization that makes a call into native code. The change is making sure that a single instance of the QueryPartitionProvider created and shared between all the query requests. It is possible because provider does not hold container specific data. The change can improve light weight query requests by ~1.7%
Type of change