Compare case for default(PartitionKey) #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
previously approved these changes
Mar 26, 2020
j82w
previously approved these changes
Mar 26, 2020
j82w
approved these changes
Mar 26, 2020
Closed
1 task
kirankumarkolli
pushed a commit
that referenced
this pull request
Apr 27, 2020
* Partitionkey add methods for comparison (#1265) * Implements comparrision operators, methods * Add test for partition key comparison * changelog * Refactor Equals Method * Update SDKAPI * Refactor tests * Sort TypeTree by InvariantComparer * Remove IComparable form PartitionKey * Update DotNetSDKAPI.json * undo * Compare case for default(PartitionKey) (#1312) * default case * changelog * tests * contract Co-authored-by: Kristián Jakubík <jakubikkristian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
PartitionKeyis a struct.default(struct)initializes all referenced properties to their default values (ref https://docs.microsoft.com/dotnet/csharp/language-reference/language-specification/structs#class-and-struct-differences)Due to this behavior, comparisons using
default(PartitionKey)were causing NullRefs.This PR handles the case of
default(PartitionKey)by assigning it theNullvalue for comparison purposes.Type of change
Closing issues
Closes #1307