CosmosClient now throws ObjectDisposedException #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the client is disposed
j82w
requested review from
bchong95,
kirankumarkolli and
kirillg
as code owners
bchong95
reviewed
Mar 12, 2020
ealsur
reviewed
Mar 13, 2020
kirankumarkolli
previously approved these changes
Mar 16, 2020
added 4 commits
March 17, 2020 06:44
kirankumarkolli
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This makes the ClientContext disposable and throws the an exception when trying to doing any calls with a disposed client.
This refactors the client and several properties to use the ClientContext to ensure all calls will throw the correct disposed exception.
Type of change
Please delete options that are not relevant.
Closing issues
#420