Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Tcp settings to CosmosClientOptions #100

Closed
wants to merge 9 commits into from

Conversation

ausfeldt
Copy link
Contributor

@ausfeldt ausfeldt commented Mar 29, 2019

public class ComsosClientOptions
{
   ...
  public Nullable<TimeSpan> IdleTcpConnectionTimeout { get; set; }
  public Nullable<int> MaxRequestsPerTcpConnection { get; set; }      
  public Nullable<int> MaxTcpConnectionsPerEndpoint { get; set; }
  public Nullable<TimeSpan> OpenTcpConnectionTimeout { get; set; } 
   ...
}

Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model them as overloads to UseConnectionModeDirect method.

j82w
j82w previously approved these changes Apr 18, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resovle the conflicts.

@kirankumarkolli
Copy link
Member

It needs to be reworked with the new fluent pattern under discussion.

@ausfeldt ausfeldt self-assigned this May 9, 2019
@ausfeldt ausfeldt force-pushed the users/gaausfel/add_directTcp_settings branch from 011d8c2 to eff904a Compare June 12, 2019 00:28
Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/CosmosClientOptions.cs Outdated Show resolved Hide resolved
REDMOND\gaausfel added 2 commits June 12, 2019 10:54
@kirankumarkolli
Copy link
Member

Missing contract update & change log comments.

Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing change-log, contract refresh, conflicts.

@kirankumarkolli kirankumarkolli changed the title Add direct/tcp settings Configurable Tcp settings to CosmosClientOptions Aug 15, 2019
@ausfeldt
Copy link
Contributor Author

#708

@ausfeldt ausfeldt closed this Aug 15, 2019
@kirankumarkolli kirankumarkolli deleted the users/gaausfel/add_directTcp_settings branch May 23, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants