From 94c83f58ed9f83b36b5e42b6a5187b579f666d0d Mon Sep 17 00:00:00 2001 From: Nimit Shah Date: Mon, 27 Feb 2023 07:53:21 -0800 Subject: [PATCH] Diagnostics: Adds startDate in Summary (#3707) * Adding start date * Updated trace files * PR comment * Committing missing tests --------- Co-authored-by: Matias Quaranta --- .../Tracing/TraceWriter.TraceJsonWriter.cs | 4 ++-- .../Tracing/TraceWriter.TraceTextWriter.cs | 1 + ...iterBaselineTests.BatchOperationsAsync.xml | 2 +- ...riterBaselineTests.BulkOperationsAsync.xml | 22 +++++++++---------- ...aceWriterBaselineTests.ChangeFeedAsync.xml | 10 ++++----- ...eWriterBaselineTests.MiscellanousAsync.xml | 4 ++-- ...neTests.PointOperationsExceptionsAsync.xml | 12 +++++----- ...EndTraceWriterBaselineTests.QueryAsync.xml | 14 ++++++------ ...TraceWriterBaselineTests.ReadFeedAsync.xml | 8 +++---- ...TraceWriterBaselineTests.ReadManyAsync.xml | 4 ++-- ...selineTests.StreamPointOperationsAsync.xml | 8 +++---- ...aselineTests.TypedPointOperationsAsync.xml | 8 +++---- ...raceWriterBaselineTests.ScenariosAsync.xml | 6 ++--- ...TraceWriterBaselineTests.Serialization.xml | 14 ++++++------ .../TraceWriterBaselineTests.TraceData.xml | 14 ++++++------ 15 files changed, 66 insertions(+), 65 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs index 4710f00a2e..74363c8ca1 100644 --- a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs +++ b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs @@ -46,8 +46,8 @@ public static void WriteTrace( if (isRootTrace) { - writer.WriteFieldName("start time"); - writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString)); + writer.WriteFieldName("start datetime"); + writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateTimeFormatString)); } writer.WriteFieldName("duration in milliseconds"); writer.WriteNumber64Value(trace.Duration.TotalMilliseconds); diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs index f77307b359..502c87c4fe 100644 --- a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs +++ b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs @@ -18,6 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing internal static partial class TraceWriter { internal static readonly string HourTimeFormatString = "HH:mm:ss:fff"; + internal static readonly string DateTimeFormatString = "yyyy-MM-ddTHH:mm:ss.fffZ"; private static class TraceTextWriter { diff --git a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml index 59a5eabf76..d468fe87f5 100644 --- a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml +++ b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml @@ -61,7 +61,7 @@ @@ -71,7 +71,7 @@