Proposal: Add Dockerfile.spot? #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twitchax
approved these changes
Jul 3, 2018
Codecov Report
@@ Coverage Diff @@
## dev #6716 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 145 145
Branches 11 11
===================================
Misses 145 145Continue to review full report at Codecov.
|
|
Mind add a few comments in the source? |
|
Sure. |
|
Yes. So that whoever read the code in the future understand what is this for. |
|
Merge once CI passes (CI actually does nothing regarding this change. Just for the formality) |
troydai
approved these changes
Jul 6, 2018
|
Forgot you still have the merge privilege. |
|
Ah my bad, thought your comment was directed at me! |
|
Old habit die hard... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating 'Spots' directly from PRs in the repo.