Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eastus out of acs preview regions #4227

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

rjtsdl
Copy link
Contributor

@rjtsdl rjtsdl commented Aug 16, 2017


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@msftclas
Copy link

@rjtsdl,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@rjtsdl
Copy link
Contributor Author

rjtsdl commented Aug 16, 2017

Fix #4222

@rjtsdl
Copy link
Contributor Author

rjtsdl commented Aug 16, 2017

@derekbekoe, please help to merge, when it is green. :)

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #4227 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4227   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files         475      475           
  Lines       29602    29602           
  Branches     4539     4539           
=======================================
  Hits        20736    20736           
+ Misses       7422     7418    -4     
- Partials     1444     1448    +4
Impacted Files Coverage Δ
...e-cli-acs/azure/cli/command_modules/acs/_params.py 76.71% <100%> (ø) ⬆️
...nent/azure/cli/command_modules/component/custom.py 16.26% <0%> (ø) ⬆️
...dback/azure/cli/command_modules/feedback/custom.py 31.25% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/util.py 70.66% <0%> (ø) ⬆️
...li-cloud/azure/cli/command_modules/cloud/custom.py 13.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73657b5...0c6c93e. Read the comment docs.

@derekbekoe
Copy link
Member

@rjtsdl We just released so please resync with master and update the PR.
Currently HISTORY.rst looks incorrect.

@rjtsdl rjtsdl force-pushed the jiren-removeeastus branch from c97842c to 0c6c93e Compare August 16, 2017 03:22
@derekbekoe derekbekoe merged commit 77ab298 into Azure:master Aug 16, 2017
@rjtsdl rjtsdl deleted the jiren-removeeastus branch August 16, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants