[Compute] BREAKING CHANGE: Remove unversioned image aliases #27566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
|
Compute |
ReaNAiveD
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
kairu-ms,
necusjz,
evelyn-ys,
jiasli and
calvinhzy
as code owners
…versioned-aliases
…versioned-aliases # Conflicts: # src/azure-cli/azure/cli/command_modules/monitor/tests/latest/test_monitor_autoscale.py
zhoxing-ms
reviewed
Oct 17, 2023
| @@ -58,7 +58,7 @@ | |||
| vm_secrets=$(az vm secret format -s "$secrets") | |||
|
|
|||
| az vm create -g group-name -n vm-name --admin-username deploy \\ | |||
| --image debian --secrets "$vm_secrets" | |||
| --image Debian:debian-10:10:latest --secrets "$vm_secrets" | |||
There was a problem hiding this comment.
The sample should use the recommended Debian version
Suggested change
| --image Debian:debian-10:10:latest --secrets "$vm_secrets" | |
| --image Debian11 --secrets "$vm_secrets" |
zhoxing-ms
reviewed
Oct 17, 2023
| @@ -166,7 +166,7 @@ | |||
| vm_secrets=$(az vm secret format -s "$secrets") | |||
|
|
|||
| az vm create -g group-name -n vm-name --admin-username deploy \\ | |||
| --image debian --secrets "$vm_secrets" | |||
| --image Debian:debian-10:10:latest --secrets "$vm_secrets" | |||
There was a problem hiding this comment.
Suggested change
| --image Debian:debian-10:10:latest --secrets "$vm_secrets" | |
| --image Debian11 --secrets "$vm_secrets" |
zhoxing-ms
previously approved these changes
Oct 18, 2023
necusjz
previously approved these changes
Oct 18, 2023
AllyW
previously approved these changes
Oct 18, 2023
evelyn-ys
previously approved these changes
Oct 18, 2023
…versioned-aliases # Conflicts: # src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_copy_vm_restore_point.yaml # src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vmss_update_custom_data.yaml
necusjz
dismissed stale reviews from evelyn-ys, AllyW, zhoxing-ms, and themself
via
e42d592
zhoxing-ms
approved these changes
Oct 20, 2023
AllyW
approved these changes
Oct 20, 2023
necusjz
approved these changes
Oct 20, 2023
evelyn-ys
approved these changes
Oct 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
All commands using image aliases
Description
Resolve #27564
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.