[ARM] Fix: az bicep install: Use CA bundle environment variables if set
#26013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
ghost
added
the
customer-reported
|
Thank you for your contribution wwmoraes! We will review the pull request and get back to you soon. |
|
ARM |
ghost
requested a review
from
ghost
added
the
ARM
shenglol
previously approved these changes
Apr 11, 2023
|
@zhoxing-ms Could you take a look at the PR? Thanks. @wwmoraes It seems there are code style errors to fix. The CI logs expired, but you can see the errors locally by running |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
reviewed
Apr 18, 2023
Comment on lines
135
to
140
| context = ssl.create_default_context(cafile=( | ||
| os.environ.get("REQUESTS_CA_BUNDLE") | ||
| or os.environ.get("CURL_CA_BUNDLE") | ||
| or certifi.where() | ||
| )) | ||
| request = urlopen(_get_bicep_download_url(system, release_tag, target_platform=target_platform), context=context) |
There was a problem hiding this comment.
Could we consider using requests.get instead of urlopen, which may make the code more concise and consistent with the approach of get_bicep_available_release_tags() and get_bicep_latest_release_tag()
Could you please resolve these flake8 related issues? |
zhoxing-ms
modified the milestones:
April 2023 (2023-04-25),
May 2023 (2023-05-23) - For Build (Breaking change release)
|
@wwmoraes Any update? |
added a fallback order equivalent to the one found in the requests package. Also removed the unneeded setdefaults.
️✔️AzureCLI-BreakingChangeTest
|
|
The individual test case reported as an error works fine when ran directly with It is beyond the objective of this PR to refactor this entire suite of unit tests. @zhoxing-ms would you be so kind as to review it once again? |
zhoxing-ms
reviewed
Jun 7, 2023
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource_bicep.py
Show resolved
Hide resolved
I guess we can solve this CI problem through mock @mock.patch("azure.cli.command_modules.resource._bicep._get_bicep_installation_path")
@mock.patch("azure.cli.command_modules.resource._bicep._get_bicep_installed_version")@shenglol Do you have any thoughts or suggestions regarding this testing issue? |
It seems the |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
August 2023 (2023-09-05),
September 2023 (2023-09-26)
zhoxing-ms
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
zhoxing-ms
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
zhoxing-ms
modified the milestones:
January 2024 (2024-02-06),
February 2024 (2024-03-05)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az bicep installDescription
Added a fallback order equivalent to the one found in the requests package. Also removed the unneeded setdefaults. See #21807 for history, and the recent comment done by @jiasli
closes #26007
Testing Guide
A clean environment should use the certifi CA bundle path:
If either
REQUESTS_CA_BUNDLEorCURL_CA_BUNDLEis set, then it should be picked up:If both
REQUESTS_CA_BUNDLEandCURL_CA_BUNDLEare set, then it should useREQUESTS_CA_BUNDLE(this is by definition of the requests package).History Notes
[ARM]
az bicep install: Use CA bundle environment variables if setThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.