Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AppConfig} Fix #13498958: Fix errors with az appconfig revision list when using customized fields #21419

Merged
merged 6 commits into from
Feb 25, 2022

Conversation

pratiksanglikar
Copy link
Contributor

@pratiksanglikar pratiksanglikar commented Feb 23, 2022

Description
Fixes #13498958 Fix errors with 'az appconfig revision list' when using customized fields


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested a review from yonzhan February 23, 2022 18:59
@ghost ghost assigned zhoxing-ms Feb 23, 2022
@ghost ghost added this to the Feb 2022 (2022-03-01) milestone Feb 23, 2022
@ghost ghost added the App Configuration label Feb 23, 2022
Copy link
Contributor

@shenmuxiaosen shenmuxiaosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 23, 2022

AppConfig

@wangzelin007
Copy link
Member

@pratiksanglikar,
Please re-record the failed tests.
image
And fix the conflicting file:
src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/export_features_prop.json

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratiksanglikar Could you solve the CI issue and conflicts by tomorrow?
If not, this PR will not be able to catch up with the release of this sprint and can only be postponed to the next sprint (04-05)

@pratiksanglikar
Copy link
Contributor Author

@zhoxing-ms let's merge this PR and take it in the current sprint.

@zhoxing-ms zhoxing-ms merged commit 99e1959 into Azure:dev Feb 25, 2022
@pratiksanglikar pratiksanglikar deleted the prsangli-fields branch February 25, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants