Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 3.4 support #11432

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Conversation

fengzhou-msft
Copy link
Member

Fix #11391

@yungezz
Copy link
Member

yungezz commented Dec 2, 2019

what's the whole plan of remove python 3.4 support, such as plan for users using 3.4 today

@yonzhan yonzhan added this to the S162 milestone Dec 2, 2019
@fengzhou-msft
Copy link
Member Author

what's the whole plan of remove python 3.4 support, such as plan for users using 3.4 today

Current azure-cli code already breaks with python 3.4, this is to remove python 3.4 from language support list.

@haroldrandom
Copy link
Contributor

@fengzhou-msft Could you reference some issues or problems?

Offering a case, but not related to OpenSSL.
I test to install azure-cli in Ubuntu 18.04 under Python 3.4. Breaks by requests~2.22 not supported.

image

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 6, 2019

@fengzhou-msft Share we add Python 3.8 support in all setup.py recently?

@fengzhou-msft
Copy link
Member Author

@fengzhou-msft Share we add Python 3.8 support in all setup.py recently?

We have done that for the main packages in last sprint. I added it in the remaining setup.py files in this PR.

@fengzhou-msft fengzhou-msft merged commit 4f89b70 into Azure:dev Dec 9, 2019
@fengzhou-msft fengzhou-msft deleted the remove_python_3_4 branch December 9, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Python 3.4
4 participants