AKS: Get VM SKU details from backend for validation for Azure Container Storage #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukhoakash
requested review from
andyliuliming and
FumingZhang
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @mukhoakash, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
…into mukhoakash/update_vm_sku_lookup
FumingZhang
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Is there any existing test case could help validate the change? If so, please queue live test pipeline to help validate, otherwise, please add a new one.
|
Please fix failed CI checks (both test cases and style check). |
mukhoakash
force-pushed
the
mukhoakash/update_vm_sku_lookup
branch
from
4e6fe67
to
b61910a
Compare
|
Queued live tests. |
mukhoakash
force-pushed
the
mukhoakash/update_vm_sku_lookup
branch
from
2e0cdbe
to
6b72975
Compare
mukhoakash
force-pushed
the
mukhoakash/update_vm_sku_lookup
branch
from
6b72975
to
dcbf0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.