Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Fabric Extension: Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension. #6887

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

smylsamy
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 21, 2023

❌Azure CLI Extensions Breaking Change Test
❌managednetworkfabric
rule cmd_name rule_message suggest_message
1007 - ParaRemove networkfabric acl create cmd networkfabric acl create removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric acl create
1007 - ParaRemove networkfabric acl create cmd networkfabric acl create removed parameter match_conf please add back parameter match_conf for cmd networkfabric acl create
1007 - ParaRemove networkfabric acl update cmd networkfabric acl update removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric acl update
1007 - ParaRemove networkfabric acl update cmd networkfabric acl update removed parameter match_conf please add back parameter match_conf for cmd networkfabric acl update
1006 - ParaAdd networkfabric ipcommunity create cmd networkfabric ipcommunity create added parameter ip_community_rules please remove parameter ip_community_rules for cmd networkfabric ipcommunity create
1007 - ParaRemove networkfabric ipcommunity create cmd networkfabric ipcommunity create removed parameter ip_comm_rules please add back parameter ip_comm_rules for cmd networkfabric ipcommunity create
1007 - ParaRemove networkfabric ipcommunity update cmd networkfabric ipcommunity update removed parameter ip_comm_rules please add back parameter ip_comm_rules for cmd networkfabric ipcommunity update
1006 - ParaAdd networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create added parameter ip_extended_community_rules please remove parameter ip_extended_community_rules for cmd networkfabric ipextendedcommunity create
1007 - ParaRemove networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create removed parameter ip_ext_comm_rules please add back parameter ip_ext_comm_rules for cmd networkfabric ipextendedcommunity create
1007 - ParaRemove networkfabric ipextendedcommunity update cmd networkfabric ipextendedcommunity update removed parameter ip_ext_comm_rules please add back parameter ip_ext_comm_rules for cmd networkfabric ipextendedcommunity update
1007 - ParaRemove networkfabric taprule create cmd networkfabric taprule create removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric taprule create
1007 - ParaRemove networkfabric taprule create cmd networkfabric taprule create removed parameter polling_interval please add back parameter polling_interval for cmd networkfabric taprule create
1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter match_configurations: updated property options from ['--match-conf'] to ['--match-configurations'] please change property options from ['--match-configurations'] to ['--match-conf'] for parameter match_configurations of cmd networkfabric taprule create
1007 - ParaRemove networkfabric taprule update cmd networkfabric taprule update removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric taprule update
1010 - ParaPropUpdate networkfabric taprule update cmd networkfabric taprule update update parameter match_configurations: updated property options from ['--match-conf'] to ['--match-configurations'] please change property options from ['--match-configurations'] to ['--match-conf'] for parameter match_configurations of cmd networkfabric taprule update
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter dynamic_match_configurations
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter match_configurations
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter dynamic_match_configurations
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter match_configurations
⚠️ 1006 - ParaAdd networkfabric ipcommunity update cmd networkfabric ipcommunity update added parameter ip_community_rules
⚠️ 1006 - ParaAdd networkfabric ipextendedcommunity update cmd networkfabric ipextendedcommunity update added parameter ip_extended_community_rules
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter dynamic_match_configurations
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter polling_interval_in_seconds
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter dynamic_match_configurations

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 21, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@smylsamy smylsamy changed the title Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension. Network Fabric Extension: Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension. Oct 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Oct 21, 2023
@kairu-ms kairu-ms merged commit 48bf4c5 into Azure:main Oct 23, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=98848&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants