Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] az containerapp service milvus: Add support for milvus dev service #6863

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

bgashirabake
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp service milvus sub group containerapp service milvus added

@azure-client-tools-bot-prd
Copy link

Hi @bgashirabake,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 17, 2023
@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2023

az containerap service create

@bgashirabake bgashirabake changed the title [az containerap service create] add support for milvus dev service [az containerapp service create] add support for milvus dev service Oct 17, 2023
@bgashirabake bgashirabake changed the title [az containerapp service create] add support for milvus dev service [az containerapp service milvus] add support for milvus dev service Oct 17, 2023
@Greedygre
Copy link
Contributor

Recommend title: [containerapp] az containerapp service milvus: Add support for milvus dev service
Here is the guidance: Format PR Title

@bgashirabake bgashirabake changed the title [az containerapp service milvus] add support for milvus dev service [containerapp] az containerapp service milvus: Add support for milvus dev service Oct 18, 2023
@bgashirabake
Copy link
Contributor Author

@zhoxing-ms could you please take a look. thank you.

@yanzhudd yanzhudd merged commit d6d11c9 into Azure:main Oct 23, 2023
14 checks passed
Greedygre added a commit to Greedygre/azure-cli-extensions that referenced this pull request Oct 24, 2023
yanzhudd pushed a commit that referenced this pull request Oct 24, 2023
@tawalke
Copy link

tawalke commented Nov 6, 2023

Can we reopen this PR given it was reverted and we need to have Milvus CLI ready for Ignite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants