Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp support additional port mappings #6594

Merged

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Aug 3, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create/show/list/delete
az containerapp auth show/update
with use api-version 2023-05-02-preview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 3, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 3, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre
Copy link
Contributor Author

1.wait api-version 2023-05-02-preview release
2.rerun all tests with --live

@Greedygre Greedygre force-pushed the xinyu/support_additional_port_mappings2 branch from 26dee9f to 5737281 Compare August 7, 2023 06:06
@Greedygre Greedygre marked this pull request as ready for review August 7, 2023 06:07
@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
This PR has been reviewd by zunli, could you please help to review and approve? Thanks a lot.

@zhoxing-ms zhoxing-ms merged commit d4a2155 into Azure:main Aug 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants