Add --enable-cilium-dataplane to AKS cluster create #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --enable-cilium-dataplane flag causes `az aks create` to set networkProfile.ebpfDataplane=cilium in the PUT ManagedCluster API call (requires AKS 20220902preview API).
ghost
requested review from
ghost
assigned 
paulgmiller
reviewed
Oct 18, 2022
| @@ -215,6 +215,12 @@ | |||
| Using together with "azure" network plugin. | |||
| Specify "azure" for Azure network policy manager and "calico" for calico network policy controller. | |||
| Defaults to "" (network policy disabled). | |||
| - name: --enable-cilium-dataplane | |||
There was a problem hiding this comment.
--ebp-dataplane cillium to be more consistent with api?
paulgmiller
approved these changes
Oct 18, 2022
|
AKS |
FumingZhang
reviewed
Oct 19, 2022
There was a problem hiding this comment.
LGTM
Queued a pipeline to test the newly added case. Passed.
FumingZhang
approved these changes
Oct 19, 2022
zhoxing-ms
approved these changes
Oct 19, 2022
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=9668&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --enable-cilium-dataplane flag causes
az aks createto set networkProfile.ebpfDataplane=cilium in the PUT ManagedCluster API call (requires AKS 20220902preview API).This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks createGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:- [ ] My extension description/summary conforms to the Extension Summary Guidelines.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.