Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s-extension] Update extension CLI to v1.3.2 #5245

Merged
merged 247 commits into from
Aug 18, 2022

Conversation

bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

jonathan-innis and others added 30 commits March 10, 2021 13:25
[pull] release from Azure:master
* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import
…es/azure-cli-extensions into k8s-extension/public
bavneetsingh16 and others added 17 commits August 9, 2022 18:38
…_fix

CI fix: deprecate python version 3.6 use in testing
Co-authored-by: root <root@longlongwan.localdomain>
Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
* add omsagent rename changes

* fix flake8 errors

Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
* Always show TSG link for AzureMLKubernetes extension at the head

* refine tsg message

* refine tsg message

* move to 1.3.1 release

* remove space

Co-authored-by: Ubuntu <zetia@DevBox-zetia.1jltvvkrfgyuhl3llhmbyldkog.bx.internal.cloudapp.net>
Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
Co-authored-by: Gaurav Gupta <gaurgupta@microsoft.com>
@ghost ghost requested a review from yonzhan August 17, 2022 17:35
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 17, 2022
@ghost ghost requested a review from zhoxing-ms August 17, 2022 17:35
@ghost ghost assigned zhoxing-ms Aug 17, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 17, 2022
@ghost ghost requested a review from wangzelin007 August 17, 2022 17:35
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 17, 2022

k8s-extension

@zhoxing-ms
Copy link
Contributor

Could you add some tests for this change?

@bavneetsingh16
Copy link
Contributor Author

Currently all the testing is done in our forked repository,
pr initiated CI check - https://github.com/AzureArcForKubernetes/azure-cli-extensions/blob/k8s-extension/public/testing/pipeline/k8s-custom-pipelines.yml
CI check for each partner extension - https://github.com/AzureArcForKubernetes/azure-cli-extensions/tree/k8s-extension/public/testing/test/extensions/public

We had got an exception for our cli tests, the checks performed in this repository are basically using the recording file present in 'k8s-extension/azext_k8s_extension/tests/latest/recordings/test_k8s_extension.yaml'.

As mentioned in the comments for this pr: #5204 , just as we will be working on supporting testing for provisionedClusters we will alsoworking to support testing for appliances(currently needs special hardware configuration). Currently testing for appliances and provisionedClusters is only done manually and it has been verified. These changes were tested against other clusterTypes for which we support testing in our forked repo and it passed and only then this pr was created.

@zhoxing-ms zhoxing-ms merged commit 203ec06 into Azure:main Aug 18, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ k8s-extension ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results

pfrcks pushed a commit to pfrcks/azure-cli-extensions that referenced this pull request Dec 1, 2022
* [k8s-extension] Update extension CLI to v1.3.2 (Azure#5245)

* [Release] Update index.json for extension [ k8s-extension ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results

Last commit: Azure@203ec06

* [IoT] IoT Extension Release v0.17.0 (Azure#5249)

* [TA] change rolebinding create command parameter roles to comma-seperated (Azure#5166)

* Update `aks kollect` command to use Periscope version 0.0.10 (Azure#5248)

* bump k8s-extension version to 1.3.3

Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com>
Co-authored-by: Victoria Litvinova <73560279+vilit1@users.noreply.github.com>
Co-authored-by: Yitong Feng <369397590@qq.com>
Co-authored-by: peterbom <peter.bomber@microsoft.com>
Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.